Skip to content

Add limit to the unconfirmed messages #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 27, 2025
Merged

Add limit to the unconfirmed messages #378

merged 4 commits into from
Jan 27, 2025

Conversation

Gsantomaggio
Copy link
Member

The producer is blocked when the limit is reached. It is possible to configure the limit using the producerOption.QueueSize setting.

Closes: #373

Close the TCP client connection in case of CRC fail. The panic is removed. Closes: #368

@Gsantomaggio
Add limit to the unconfirmed messages
a2b570a 
The producer is blocked when the limit is reached. It is possible to configure the
limit using the producerOption.QueueSize setting.

Closes: #373

Close the TCP client connection in case of CRC fail. The panic is removed.
Closes: #368

Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
@Gsantomaggio Gsantomaggio requested a review from hiimjako January 27, 2025 09:04
@Gsantomaggio Gsantomaggio added this to the 1.5.0 milestone Jan 27, 2025
@Gsantomaggio
Copy link
Member Author

We can release the 1.5.0-rc.1 when the PR is merged. cc @hiimjako

hiimjako
hiimjako reviewed Jan 27, 2025
View reviewed changes
Gsantomaggio and others added 3 commits January 27, 2025 10:54
@Gsantomaggio @hiimjako
Update pkg/stream/producer_unconfirmed.go
e90b093 
Co-authored-by: Alberto Moretti <58828402+hiimjako@users.noreply.github.com>
@Gsantomaggio @hiimjako
Update pkg/stream/producer_unconfirmed.go
4ef5570 
Co-authored-by: Alberto Moretti <58828402+hiimjako@users.noreply.github.com>
@Gsantomaggio
merge
d8d4460 
Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
@Gsantomaggio Gsantomaggio merged commit 7a3d780 into main Jan 27, 2025
3 checks passed
@Gsantomaggio Gsantomaggio deleted the unconfirmed_limit branch January 27, 2025 10:04
@Gsantomaggio Gsantomaggio added the enhancement New feature or request label Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiimjako hiimjako hiimjako approved these changes

Assignees

@hiimjako hiimjako

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

Add a limit to the unconfirmed list Failed CRC check should not panic
2 participants
@Gsantomaggio @hiimjako